reduxjs / redux-devtools

DevTools for Redux with hot reloading, action replay, and customizable UI
http://youtube.com/watch?v=xsSnOQynTHs
MIT License
13.93k stars 1.15k forks source link

Enable lock button for non-Redux connections. #1658

Open EskiMojo14 opened 2 months ago

EskiMojo14 commented 2 months ago

Currently the lock button is disabled if the app doesn't think it's talking to a Redux store - which is decided here: https://github.com/reduxjs/redux-devtools/blob/f019024b21e119f6e123bd1f9e2d815d295dfde6/packages/redux-devtools-app/src/reducers/instances.ts#L280

There doesn't seem to be a reason stated for this, and stores other than Redux can certainly implement locking, so I think it would be good to enable this. It's still hidden based on the feature option, which defaults to only being true if it's a Redux store: https://github.com/reduxjs/redux-devtools/blob/f019024b21e119f6e123bd1f9e2d815d295dfde6/packages/redux-devtools-app/src/reducers/instances.ts#L290

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 136ce3e45e59283cb93a7167dffdbb4a84ca87f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------- | ----- | | @redux-devtools/app | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR