search

reduxjs / redux-devtools

DevTools for Redux with hot reloading, action replay, and customizable UI
http://youtube.com/watch?v=xsSnOQynTHs
MIT License
13.93k stars 1.15k forks source link

Avoid auto-selecting instance in iFrames #1692

Open alexandcote opened 2 weeks ago

alexandcote commented 2 weeks ago

Note: First time contributing to this project, open to feedback

Avoid auto-selecting the outer frame instance when redux exists in iFrame embedded on the page.

Fix: #1000

iFrame has a different tabID than the main frame. The connections are therefore not grouped properly.

Example: 

{
  "connections": {
    "<tabId>" ["<firstConnectionID>"],
    "<iFrameTabId>": ["<secondConnectionID>"]
  }
}

Should we group those connections under the same key? The fix is working but I'm unsure if it's the right solution to the problem.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: d03eb599a8a525b928a42a226f5d5543ad33167e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------------- | ----- | | remotedev-redux-devtools-extension | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR