search

reduxjs / redux-devtools

DevTools for Redux with hot reloading, action replay, and customizable UI
http://youtube.com/watch?v=xsSnOQynTHs
MIT License
14.04k stars 1.17k forks source link

3.2.7 not working with Electron `notifications` permission is unknown #1784

Open henrikbjorn opened 2 days ago

henrikbjorn commented 2 days ago

As a follow up to #1730

It seems to be broken again in the newest release with the following errors 

(node:10569) ExtensionLoadWarning: Warnings loading extension at /Users/henrikbjornskov/Library/Application Support/reduxDevTools/extensions/lmhkpmbekcpmknklioeibfkpmmfibljd:
  Permission 'notifications' is unknown or URL pattern is malformed.
  Permission 'contextMenus' is unknown or URL pattern is malformed.

(Use `Electron --trace-warnings ...` to show where the warning was created)

How I got there with this simple electron app

https://gist.github.com/henrikbjorn/041f5ebf5bdd3c64fb10a0b9a378e938

I check the version in the manifest at the extension location to make sure it is 3.2.7

Methuselah96 commented 2 days ago

I think those are just warnings, there's probably something else going on. What version of Electron are you on? The version we're currently testing against is v31, there seems to be issues when we try to upgrade to v32 or v33, I wonder if that could be it.

henrikbjorn commented 1 day ago

I just did yarn add electron it have installed 33.0.2. So it seems that might be the cause, some change between the major electron versions.