search

reduxjs / redux-devtools

DevTools for Redux with hot reloading, action replay, and customizable UI
http://youtube.com/watch?v=xsSnOQynTHs
MIT License
14.07k stars 1.17k forks source link

Support for Immutable.js Not Work Again #265

Closed lcxfs1991 closed 8 years ago

lcxfs1991 commented 8 years ago

I recently upgrade to latest redux-devtools, dock and log panel, then I found this. (also latest react 15.0.0, redux and immutable):

I then resolve it by using tips from this issue: https://github.com/gaearon/redux-devtools/issues/51

I think you have solved this problem at certain version. Could you please check if it is related to new react/redux update?

granmoe commented 8 years ago

I'm having the issue, too. Can you share the workaround? I looked at the issue you linked, but I am very new to redux-devtools and it looks like the API has changed drastically from 1.x. I'm not sure how to implement it.

gaearon commented 8 years ago

Mind looking into why this happens?

lcxfs1991 commented 8 years ago

qq 20160408160025

add a screenshot

gaearon commented 8 years ago

I don't understand what this screenshot means. Can you please clarify?

Can you find why the issue happens and which exactly update broke the support? It is not clear from the issue report.

lcxfs1991 commented 8 years ago

Usually, the tree will display like this: state | setLoading: false

I try to use toJS method for immutable object in node_modules and then it works.

I will also dig into it later in the day. I am in a rush for a project.

gaearon commented 8 years ago

Maybe @alexkuz has any ideas

lcxfs1991 commented 8 years ago

just add your Facebook. Actually strongly recommend Facebook building up stronger control over these tools, or offering an official tookits.

granmoe commented 8 years ago

I cloned redux-devtools and npm linked it in my project. I then checked out a version that I know was working with immutable.js, rebuilt and ran my project, and it still didn't work. I'm wondering if some other package is to be blame. The problem first manifested when I upgraded a bunch of packages at once, so I'll try decrement those packages back one by one and report back.

alexkuz commented 8 years ago

This is probably related to react-json-tree (there were some fixes for immutables), so it's better to create an issue there or at redux-devtools-log-monitor.

gaearon commented 8 years ago

This is most likely react-json-tree issue. Please check if it works with Immutable and if something broke please file it there. I'm closing because there is nothing specially actionable for us in this repo.

granmoe commented 8 years ago

For anyone who lands here from a search, I found the bad commit in react-json-tree using git bisect and opened an issue there: https://github.com/alexkuz/react-json-tree/issues/45