Closed aryaemami59 closed 10 months ago
same feedback as https://github.com/reduxjs/redux-templates/pull/112#pullrequestreview-1796517755 :)
This is retroactive, but I'm just now looking at the current version of the template and I feel like this has gotten over-complicated.
We don't teach combineSlices
or slice creators in the tutorials. (The "Essentials" rewrite I'm doing will mention slice creators, but only as an optional thing you can do, in a nested details section.)
I'd prefer the templates to stick closer to what we teach as the defaults.
@aryaemami59 Sorry to bother you on this one, but could you do a pass back through these templates to switch back to standard createSlice
and configureStore.reducer
usage? Basically what we had prior to this PR.
This PR:
package.json
and into.prettierrc.json
and.eslintrc.json
createAsyncThunk
withcreate.asyncThunk
createApi
, and auto-generated React hookscombineSlices
APIsetupListeners
APIcreateSlice.selectors
What else can be done: