reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.54k stars 15.28k forks source link

recommend use of an api cache library in the style guide #4178

Closed phryneas closed 3 months ago

phryneas commented 2 years ago

name: :book: Recommend use of an api cache library in the style guide about: Add a section to the style guide to use RTK Query or an alternative library.

PR Type

Update an existing page

Checklist

What docs page is being added or updated?

For Updating Existing Content

What updates should be made to the page?

Add a section to the style guide to use RTK Query or an alternative library.

Do these updates change any of the assumptions or target audience? If so, how do they change?

They add more emphasis that api cache logic should usually not be written by hand.

@markerikson generally I am very open to pretty much rewording anything in here, but we should probably get RTK-Q mentioned in the style guide.

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8f0198b4d57a614d9623b01f0b93c1bd9a04e6d:

Sandbox Source
Vanilla Typescript Configuration
netlify[bot] commented 2 years ago

✔️ Deploy Preview for redux-docs ready!

🔨 Explore the source changes: dff59986cb9a39b6aa3f0f4c9628bdeebbfd8cb9

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/6150288c04f4890008d2a2e6

😎 Browse the preview: https://deploy-preview-4178--redux-docs.netlify.app

markerikson commented 2 years ago

I'd probably put this one in the later "Recommended" section, alongside "Use Thunks".

EskiMojo14 commented 3 months ago

this seems to have been superceded by https://github.com/reduxjs/redux/pull/4460 - (https://redux.js.org/style-guide/#use-rtk-query-for-data-fetching)

okay to close?

markerikson commented 3 months ago

Yep!