reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.54k stars 15.28k forks source link

Add color property to 'code' css declaration #4589

Closed BarokDG closed 9 months ago

BarokDG commented 9 months ago

name: :memo: Documentation Fix about: Fixing a problem in an existing docs page

Checklist

What docs page needs to be fixed?

What is the problem?

It's difficult to see the text in inline code blocks inside the DetailedExplanation component in dark mode. The css doesn't match the styles used for inline code blocks on the rest of the documentation.

What changes does this PR make to fix the problem?

I added a css 'color' property to the code declaration inside website\src\css\custom.css. The value is consistent with what's used outside the DetailedExplanation component.

Before

image

After

image

codesandbox-ci[bot] commented 9 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42508c0e46eb3256b3b457bd285a0b6d12e2ca4f:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
netlify[bot] commented 9 months ago

Deploy Preview for redux-docs ready!

Name Link
Latest commit 42508c0e46eb3256b3b457bd285a0b6d12e2ca4f
Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/64d9edb52064e3000868a6c8
Deploy Preview https://deploy-preview-4589--redux-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

markerikson commented 9 months ago

Thanks!