reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.54k stars 15.28k forks source link

Update part-5-async-logic.md #4617

Closed kalyncoose closed 6 months ago

kalyncoose commented 6 months ago

Highlight next line in doc's code block as {renderedPosts} in example changes to {content} for the reader following along.


name: :memo: Documentation Fix about: Fixing a problem in an existing docs page

Checklist

What docs page needs to be fixed?

What is the problem?

An example code line needs to be highlighted to indicate to the reader that the line is being updated from previous example to code to the current example code.

What changes does this PR make to fix the problem?

Adds the // highlight-next-line comment above the line that is to be indicated to the user per the problem above.

netlify[bot] commented 6 months ago

Deploy Preview for redux-docs ready!

Name Link
Latest commit 86f90c82b1041a2d1442008f5ed19f83dce362db
Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/65547a8650ef3300086443cf
Deploy Preview https://deploy-preview-4617--redux-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 86f90c82b1041a2d1442008f5ed19f83dce362db:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
kalyncoose commented 6 months ago

Just tested and confirmed the new line highlight appears as expected in the deploy preview: https://deploy-preview-4617--redux-docs.netlify.app/tutorials/essentials/part-5-async-logic#displaying-loading-state

image

timdorr commented 6 months ago

Thanks!