reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.51k stars 15.26k forks source link

Closes #4672 Update combineReducers.md #4673

Closed Twintails closed 3 months ago

Twintails commented 3 months ago

The Docs for Redux, in many places, cite moving to configureStore. Though createStore is still available, it is also marked as deprecated. This doc may need to update to reflect modern recommendations.


name: :book: New/Updated Documentation Content about: Adding a new docs page, or updating content in an existing docs page

PR Type

Does this PR add a new page, or update an existing page? update an existing page

Checklist

What docs page is being added or updated?

at anchor https://redux.js.org/api/combinereducers#appjs code example

For Updating Existing Content

What updates should be made to the page?

lower adopter/developer confusion on the approach to Redux.

Do these updates change any of the assumptions or target audience? If so, how do they change?

This update makes a huge assumption in blending of the lines of ownership/documents of use and responsibilities between Redux and @reduxjs/toolkit

codesandbox-ci[bot] commented 3 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef9eee68d1c393a715bfc1d3ea1555a9f68309a4:

Sandbox Source
Vanilla Typescript Configuration
EskiMojo14 commented 3 months ago

thanks!

CI failures seem unrelated to this change.

it's also worth noting that configureStore often replaces the need for calling combineReducers, as it calls it automatically if passed an object as the reducer field.