reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.51k stars 15.26k forks source link

Add Expo and React Native examples to CI #4681

Closed aryaemami59 closed 2 months ago

aryaemami59 commented 2 months ago

This PR:

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

netlify[bot] commented 2 months ago

Deploy Preview for redux-docs ready!

Name Link
Latest commit 629d600aee90b18571fef1abdf24275fb36ea145
Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/65ed2e0aa0b69b0008ef110e
Deploy Preview https://deploy-preview-4681--redux-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

timdorr commented 2 months ago

Can we add any caching to this to speed things up? This slows the test suite by nearly 5x and this library isn't React-specific. This seems like overkill to me.

aryaemami59 commented 2 months ago

@timdorr Sure I can figure out some sort of caching to speed this up.

timdorr commented 2 months ago

Updated the RN examples upstream to be much much faster, but also added a cache. Thanks for getting this together!

aryaemami59 commented 2 months ago

@timdorr

Updated the RN examples upstream to be much much faster, but also added a cache. Thanks for getting this together!

That's awesome, thank you Tim! This makes me wonder, would it be okay then to re-open https://github.com/reduxjs/redux-thunk/pull/365?

timdorr commented 2 months ago

Unfortunately, I can't reopen that PR (branch is deleted). But feel free to submit a new one and we'll get it merged in.

aryaemami59 commented 2 months ago

@timdorr Thank you!!!

EskiMojo14 commented 2 months ago

i reopened it 👍🏻

aryaemami59 commented 2 months ago

@EskiMojo14 Thank you Ben!