search

reduxjs / redux

A JS library for predictable global state management
https://redux.js.org
MIT License
60.51k stars 15.26k forks source link

Update writing-logic-thunks.mdx #4682

Closed npiyush97 closed 2 months ago

npiyush97 commented 2 months ago

Thanks for the PR!

To better assist you, please select the type of PR you want to create.

Click the "Preview" tab above, and click on the link for the PR type:

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

npiyush97 commented 2 months ago

Why ? @markerikson

markerikson commented 2 months ago

The PR doesn't have any description, doesn't list any reason for the change, and just changing the name of two example functions doesn't seem like it's meaningful or helpful.

npiyush97 commented 2 months ago

yes meaningful not but when I was reading through doc fetchdata function name for a post request irked me some way,thus this pr.

EskiMojo14 commented 2 months ago

i mean, it's not impossible that a fetch request could be a POST - it's not something I'd personally recommend, but it does happen

it's also not really the point of the example 😄