Ensure `lruMemoize` correctly memoizes when `maxSize` is set to a number less than 1

reduxjs / reselect

Selector library for Redux

MIT License

19.03k stars 671 forks source link

Closed aryaemami59 closed 6 months ago

aryaemami59 commented 7 months ago

This PR:

[X] Fixes an issue with lruMemoize that would cause memoization to completely break when maxSize is set to a value that is less than 1.
[X] Adds units tests to make sure the issue is effectively resolved.

netlify[bot] commented 7 months ago

Name	Link
Latest commit	d6379b1e3a6a1c1a671926e4ef619041d1b53467
Latest deploy log	https://app.netlify.com/sites/reselect-docs/deploys/65c849d39a6e310008bfd5c7

codesandbox-ci[bot] commented 7 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d6379b1e3a6a1c1a671926e4ef619041d1b53467:

Sandbox	Source
Vanilla Typescript	Configuration

EskiMojo14 commented 6 months ago

to be honest, i'm not sure this is something we needed to account for, but ultimately it's a one character change so can't hurt.

thanks!