search

reduxjs / rtk-github-issues-example

Source code for the Redux Toolkit Advanced Tutorial
214 stars 97 forks source link

Update IssuesListPage.tsx #3

Closed bjarkihall closed 5 years ago

bjarkihall commented 5 years ago

The current page was hardcoded to 1, so when "jumping to page", the pagination wouldn't sync.

markerikson commented 5 years ago

Ah, good catch!

I'm about to rewrite the commit history to match the changes in v0.8, so I'll make sure I fix this bug as part of that rather than merging this in.

dwiyatci commented 5 years ago

Just came across the exact same issue today. Glad there's already an issue created for it :relaxed:

markerikson commented 5 years ago

Yep. I still need to rewrite the tutorial repo. Current focus is getting 1.0 out the door (hopefully in the next day or so!), and then I'll be at ReactConf this week, so I may not get to that until after the conference.

markerikson commented 5 years ago

Resolved in a history rewrite. Thanks!