search

reduxkotlin / redux-kotlin

Redux implementation for Kotlin (supports multiplatform JVM, native, JS, WASM)
https://reduxkotlin.org
MIT License
426 stars 32 forks source link

WIP: Migrate to Kotlin Gradle DSL #16

Closed AOrobator closed 5 years ago

AOrobator commented 5 years ago

The Kotlin Gradle DSL has groovy interoperability so it can be mixed and match with groovy. Therefore this PR can be merged as is, cuz the Android example is done, but ideally, the whole project should be converted.

https://docs.gradle.org/5.6.1/userguide/kotlin_dsl.html#sec:kotlin-dsl_plugin

@patjackson52

patjackson52 commented 5 years ago

lgtm, just the one comment. I'd like the tests to pass. Currently the tests only run on branches with names 'feature/' or 'bugfix/'

AOrobator commented 5 years ago

Are the test runs documented in the readme? What happens when somebody forks this repo and makes a PR? Do the tests run then?

AOrobator commented 5 years ago

It might be easier/simpler to have tests run on all branches. I created https://github.com/reduxkotlin/redux-kotlin/pull/17 with the required branch names and am closing this one out.