reduzent / netpd-instruments

instruments (synths, sequencers, utilities, etc) to be used with netpd
http://www.netpd.org
20 stars 4 forks source link

metaseq/qseq: ms set setting not included in save #51

Closed nofoto closed 8 months ago

nofoto commented 9 months ago

A metaseq set assigned to a sequence in qseq is lost when the netpd set is saved and reopened.

reduzent commented 9 months ago

I can't reprodue. The metaseq set selection in qseq3 set is restored properly. I wonder if this might be some edge case or if order plays a role. However, I tried loading qseq3 after metaseq and vice versa and it still produced a preset file that correctly loaded all settings.

Maybe you can provide a detailed step-by-step guide, starting from an empty unpatch.

reduzent commented 9 months ago

This is how it looks after loading the preset: qseq3-metaseq-set0

reduzent commented 9 months ago

This is the preset file I used for testing: test-meta-qseq-not-saving-bug.zip

nofoto commented 9 months ago

well yeah it's strange - if you go back to the file i put on discord with the bug it just refuses to save the setting in qseq; you can change it, save the netpd set and when you open it, it's gone back to master. so the problem is in that setup somehow - are you able to read the way it saves the settings to see what happens? i can't reproduce it starting from scratch either.

reduzent commented 9 months ago

Thanks for the hint and the example preset. I attached it here as reference. There is definitely something fishy going on. I used chat's debug feature (/debug to on) to print every message when loading the preset. And it contains this:

NETPD_SND: [..b] /3/qseq3/2/metaseq/length 128
NETPD_SND: [..b] /3/qseq3/2/metaseq/offset 0
NETPD_SND: [..b] /3/qseq3/2/metaseq/set -1
NETPD_SND: [..b] /3/qseq3/1/metaseq/length 16
NETPD_SND: [..b] /3/qseq3/1/metaseq/offset 0
NETPD_SND: [..b] /3/qseq3/1/metaseq/set 0

So, set 1 should be set to metaseq set 0 (-1 means master).

b2grdz261023b.zip

reduzent commented 8 months ago

@nofoto Thanks for reporting this. This was a hard one to find.