netlify[bot]
commented
2 months ago Deploy Preview for superstore-redwood-stripe ready!
| Name | Link |
|---|---|
| Latest commit | f2308f1f7b61e3f61b9acbb29ee544fccf04f4d5 |
| Latest deploy log | https://app.netlify.com/sites/superstore-redwood-stripe/deploys/67369ab52d0fa00008a0bb69 |
| Deploy Preview | https://deploy-preview-509--superstore-redwood-stripe.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This PR contains the following updates:
7.7.4->8.4.17.7.4->8.4.17.7.4->8.4.17.7.4->8.4.17.7.4->8.4.17.7.4->8.4.17.7.4->8.4.17.7.4->8.4.17.7.4->8.4.17.7.4->8.4.1Release Notes
redwoodjs/redwood (@redwoodjs/api)
### [`v8.4.1`](https://redirect.github.com/redwoodjs/redwood/releases/tag/v8.4.1) [Compare Source](https://redirect.github.com/redwoodjs/redwood/compare/v8.4.0...v8.4.1) ##### Changelog ##### 🛠️ Fixesfix(dbAuth): Don't use Multi Value Headers on Vercel (#11718) by @Tobbe
Fixes a regression regarding dbAuth on Vercel introduced in RW 8Properly kill dev api-server (#11691) by @callingmedic911
Sometime the api-server doesn't get killed in time before the new instance is started. This change makes sure that we wait for the process. If it's not killed within 2 seconds with SIGTERM, we send a SIGKILL to it.Fix build with TS alias without basePath (#11693) by @callingmedic911
It fixes the build process for a project with TypeScript path alias. It uses root directory as the fallback if there's no baseUrl in `tsconfig.json`.breaking(rsc): Removing live-reload RSC dev server approach (#11648) by @Tobbe
Please see #11648 for more detailsfeat(baremetal): Check available disk space (#11469) by @Tobbe
Adds an early step to the `yarn rw deploy baremetal` command that checks to make sure there is enough free disk space on the server before continuing. By default it will make sure there is at least 2048 MB (2 GB) of free disk space but this can be changed by setting the new `deploy.toml` option `freeSpaceRequired` to however many MB you want. You can skip this step by passing `--no-df` to the `deploy baremetal` command or setting `freeSpaceRequired` to `0`.fix(jobs): merge job options to prevent 'undefined' values in place of defaults (#11666) by @Josh-Walker-GM
Please see #11666 for more detailsfix(jobs): Fixes creating worker with deleteSuccessfulJobs config setting in JobManager (#11653) by @dthyresson
According to the Job documentation, the JobManager's ` deleteSuccessfulJobs ` can be used to decide if one wants successfully completed jobs from being deleted from the `BackgroundJobs` table. Keeping job run history around is useful for reporting purposes, such s hoe many jobs run over time, how many fails, how many successes, etc. However, the `deleteSuccessfulJobs` was not being correctly passed to the worker in `createWorker` so the worker always used the default value -- true -- and always deleted the job run record regardless of configuration. This PR fixes this issue by setting the config value when creating the worker.fix(crwa): Add missing quotes to seed example (#11651) by @Tobbe
Just un-commenting the example seed code now gives you valid code to seed your database withfix(web) type NonSuspenseCellQueryResult... (#11639) by @richard-stafflink
The result you get back as `queryResult` is now properly typed. Typically the type will be something like `FindPostById`, i.e. the first type that is passed to `CellSuccessProps` (instead of just being `any`).fix(crwa): Better handling of installing to . (#11645) by @Tobbe
When installing to `cwd`: - Print "the current directory" instead of "." - Skip the output of `cd` (which would move you to your home directory, which most likely is not what you want)docs(deploy): fix grove command (#11689) by @Josh-Walker-GM
Please see #11689 for more detailsdocs: fix versioned docs (#11643) by @Josh-Walker-GM
Please see #11643 for more detailsRemoved 'Azure' as deploy provider mention' (#11116) by @pantheredeye
Please see #11116 for more detailsFix email link in tutorial (#11636) by @cannikin
Please see #11636 for more detailsUpdate the Deployment step of the tutorial for GROVE (#10890) by @cannikin
Please see #10890 for more detailsClick to see all dependency updates
Click to see all chore contributions
Click to see all chore contributions
chore(deps): Upgrade to React 19 RC 20240916 (#11575) by @Tobbe
Please see #11575 for more detailsfix `NODE_OPTIONS` env forwarding (#11587) by @cometkim
This change updates how we pass through any `NODE_OPTIONS` when you run the API side development server with `yarn rw dev`. Previously there may have been issues like unescaped spaces in paths which would have produced errors like: api | node:events:497 api | throw er; // Unhandled 'error' event api | ^ api | api | Error: spawn space.js --enable-source-maps ENOENT api | at ChildProcess._handle.onexit (node:internal/child_process:286:19) api | at onErrorNT (node:internal/child_process:484:16) api | at process.processTicksAndRejections (node:internal/process/task_queues:82:21) api | Emitted 'error' event on ChildProcess instance at: api | at ChildProcess._handle.onexit (node:internal/child_process:292:12) api | at onErrorNT (node:internal/child_process:484:16) api | at process.processTicksAndRejections (node:internal/process/task_queues:82:21) { api | errno: -2, api | code: 'ENOENT', api | syscall: 'spawn space.js --enable-source-maps', api | path: 'space.js --enable-source-maps', api | spawnargs: [ api | 'yarn', api | 'nodemon', api | '--quiet', api | '--watch', api | '/Users/jgmw/Development/redwood/rw-test/node_options_fix/redwood.toml', api | '--exec', api | 'yarn rw-api-server-watch --port 8911 --debug-port 18911 | rw-log-formatter' api | ] api | } api | api | Node.js v20.17.0 Now these sort of error should no longer occur.fix(dbAuth): Fix WebAuthn when authModelAccessor is set to a custom value (#11605) by @antonmoiseev
Previously if you had setup dbAuth with WebAuthn support and had chosen to rename the `User` and `UserCredential` models to some other name, such as `Account` and `AccountCredential` then dbAuth would have failed with an error something like: { "error": "this.dbCredentialAccessor.findFirst(...).user is not a function" } This change fixes the database access so that it correctly takes into account the configured `authModelAccessor`. **Note**: You should ensure your WebAuthn table has a unique index applied on the configured `id` column. Something like what our setup command generates will work great: model UserCredential { id String @id // <-- Note the index! ... }Fix storybook-vite not starting when `auth.ts` contains named imports after `createAuth` (#11593) by @Philzen
This change fixes an issue with our internal storybook mocks. Previous to this you might find that your storybook would fail with an error like: 3:49:51 PM [vite] Internal server error: Transform failed with 1 error: …/web/src/auth.ts:2:9: ERROR: Expected identifier but found "," Plugin: vite:esbuild File: …/web/src/auth.ts:3:6 Expected identifier but found "," 1 | import { createAuthentication as createAuth } from '@redwoodjs/testing/dist/web/mockAuth.js' 2 | import { , createDbAuthClient } from '@redwoodjs/auth-dbauth-web'; | ^ 3 | const dbAuthClient = createDbAuthClient(); 4 | export const { This was due to a bug in our handling of imports which this change fixes.Fixes `yarn rw jobs clear` command (#11578) by @cannikin
fix(graphql): Allow including 'File' scalar by default to be disabled (#11540) by @Josh-Walker-GM
As of v8.0.0 a `File` scalar was added to your graphql schema by default. This could be problematic if you wanted to define your own `File` scalar. With this change it is now possible to disable including this scalar by default. To see how to do so look at the `Default Scalar` section of the `Graphql` docs [here](https://docs.redwoodjs.com/docs/graphql#default-scalars)Default NODE_ENV to "development" if it's `undefined` when starting jobs worker (#11572) by @cannikin
This mimics the behavior of `yarn rw dev` where `NODE_ENV` will equal `development` if you don't set it explicitly.Revert "fix(rsc): Set a yarn resolution for rollup 4.21.3 (#11592)" (#11600) by @Tobbe
Please see #11600 for more detailsfix(rsc): Set a yarn resolution for rollup 4.21.3 (#11592) by @Tobbe
Please see #11592 for more detailsfix(docs): warn that uploads/storage is experimental (#11590) by @Josh-Walker-GM
Please see #11590 for more detailsClick to see all dependency updates
Click to see all chore contributions
Click to see all chore contributions
feat(cli): Make scaffolded layout routing type-safe (#11542) by @Tobbe
With this feature we now make sure only valid route names are passed as `titleTo` and `buttonTo` props to the scaffolded layout. This also means you get helpful code completion when typing out the prop values[gh11385] Updated the generated page template (#11533) by @ahaywood
This change alters the default content produced when you generate page with `yarn rw g page`. Previously our generated content contained code that would error out if you had a route parameter in your page - because the link we automatically generated would not contain a value for that parameter.fix(scaffold): Use plain strings in NamesCell template (#11546) by @Tobbe
Please see #11546 for more detailsfix(crwrsca): Spawn in shell on Windows (#11565) by @Tobbe
Please see #11565 for more detailsfix(crwa): silence telemetry errors (#11557) by @Josh-Walker-GM
Please see #11557 for more detailsfix(crwrsca): Check for Node >= 20.10.0 (#11544) by @Tobbe
Please see #11544 for more detailsdocs(uploads): Tweaks from updating the Recipes example app (#11571) by @Tobbe
Please see #11571 for more detailsdocs(how-to): replace crypto-js with node's crypto module for random number generation in passwordless auth (#11568) by @antonmoiseev
Please see #11568 for more detailsdocs(how-to): Fix example in dbauth-passworless docs (#11567) by @Tobbe
Please see #11567 for more detailsDocs: Use Redwood's hashPassword() for loginToken hashing in the password-less dbAuth flow (#11566) by @antonmoiseev
Please see #11566 for more detailsReplace MetaTags with Metadata component (#11564) by @antonmoiseev
Please see #11564 for more detailsdocs(chore): Fix formatting (#11524) by @Tobbe
Please see #11524 for more detailsClick to see all dependency updates
Click to see all chore contributions
Click to see all chore contributions
fix(cli): handle both single and double quotes during dbAuth setup (#11534) by @Josh-Walker-GM
If you had changed your prettier config to use double quotes instead of the default single quotes then the `yarn rw setup auth dbAuth` would fail. This change fixes that command to work regardless of quote flavour.fix(auth0): avoid use of undefined global in browser environment (#11531) by @Josh-Walker-GM
The Auth0 auth provider was failing in the browser due to trying to access `global`. This change corrects this and fixes Auth0 usage in the browser.Click to see all chore contributions
feat(uploads): Add setup command (#11423) by @dac09
Please see #11423 for more detailsfix: update community discussion link in output from cli - yarn rw upgrade (#11468) by @jgal1
Please see #11468 for more detailsfix(cli): explicitly set the version so `--version` works (#11461) by @Josh-Walker-GM
Please see #11461 for more detailsfix(jobs): Make deleteSuccessfulJobs configurable (#11459) by @Tobbe
Make the jobs Executor respect the `deleteSuccessfulJobs` config optionfix(linting): Re-enable babel presets during linting of javascript projects (#11458) by @Josh-Walker-GM
The `yarn rw lint` command was failing for JavaScript projects. This change re-enables certain babel plugins to correct this issue and allow this command to succeed again.fix(resolutions): Remove rehackt resolution (#11447) by @Tobbe
The rehackt resolution isn't needed anymore. Apollo Client has updated to rehackt 0.1.0. See https://github.com/apollographql/apollo-client/blob/HEAD/CHANGELOG.md#3101 Unfortunately this requires our users to manually go and update their resolutionsUpdates SDL codegen to handle prettier 3 correctly (#11446) by @orta
Please see #11446 for more detailsfix(rsc): Don't run the Vite dev server in production (#11425) by @Tobbe
Please see #11425 for more detailsfix(rsa): Use dist filenames when registering server references (#11417) by @Tobbe
Please see #11417 for more detailsCorrect Note Admonition (#11455) by @pantheredeye
Please see #11455 for more detailsdocs(uploads): Add upload docs (#11398) by @dac09
Please see #11398 for more detailsClick to see all dependency updates
Click to see all chore contributions
Click to see all chore contributions
deps(react): 18.3.1 (#10885) by @Tobbe
Please see #10885 for more detailsfix(template): Set scripts/ module resolution to match api/ (#11366) by @Tobbe
Make the module resolution for `scripts/` be more predictable/stable, and match that of `api/` See also [https://github.com/redwoodjs/redwood/pull/11170](https://redirect.github.com/redwoodjs/redwood/pull/11170)fix(tsconfig): set "module" to "ESNext" for web/tsconfig.json (#11368) by @Tobbe
Please see #11368 for more detailsrefactor(forms): Build with esbuild and add conditional exports (#11338) by @Josh-Walker-GM
This change introduces restrictions on what can be imported from the `@redwoodjs/forms` package. You can no longer import from `@redwoodjs/forms/dist/...`. All imports should be available simply from `@redwoodjs/forms`.refactor(prerender): build with esbuild and introduce conditional exports (#11337) by @Josh-Walker-GM
This change restricts the available imports from the `@redwoodjs/prerender` package. You will also have to use modern `moduleResolution` settings in your tsconfig to resolve the imports correctly within TS.refactor(api): Add conditional exports to package.json (#11307) by @Josh-Walker-GM
This change restricts the available imports from this package. You can no longer freely import from within the dist like `@redwoodjs/api/dist/...`. If you were doing so please consult the `@redwoodjs/api` `package.json` file to see what exports are now available.fix(internal): Move away from babel for building package (#11304) by @Josh-Walker-GM
Please see #11304 for more detailsfix: Update default tsconfig options (target, module and moduleResolution) (#11170) by @Josh-Walker-GM
This changes the default values of: - target - module - moduleResolution in the tsconfig files for both the API and web side. The benefit of this change is increased correctness for build time checking of the imports from packages which specify `exports` in their `package.json` files. This change will have a limited effect while Redwood apps are still built to CJS rather than ESM. After that switch to ESM there would be more breaking changes but they are not applied here and are a future concern.chore: brought in typescript-eslint@v8 with stylistic preset (#10911) by @JoshuaKGoldberg
This change updates Redwood linting config and introduces some changes to the linting rules that are applied to your project. Specifically: 1. `jsx-a11y/no-noninteractive-element-to-interactive-role` has it's default config updated. 2. `@typescript-eslint/explicit-function-return-type` used to be turned off, now it's no longer applied. 3. `@typescript-eslint/no-empty-interface` - used to be turned off, now it's no longer applied. 4. `@typescript-eslint/explicit-module-boundary-types` - used be turned off, now it's no longer applied. 5. `@typescript-eslint/ban-types` - used to be 'warn', now it's no longer applied. This has been replaces with a set of smaller more specific rules. 6. `no-empty-function` - used be turned off, now it's no longer applied. The ts-eslint flavour is still there and turned off still. 7. `camelcase` - used to be turned off, now it's 'warn'. 8. `@typescript-eslint/camelcase` - used to be turned off, now it's no longer applied. 9. `no-use-before-define` - used to be turned off, now it's no longer applied. 10. `@typescript-eslint/no-use-before-define` - used to be turned off, now it's no longer applied. 11. `@typescript-eslint/prefer-namespace-keyword` - used to be turned off, now it's 'error' 12. `unicode-bom` - used to be turned off, now it's no longer applied. 13. `@typescript-eslint/adjacent-overload-signatures` - used to be 'error', now it's no longer applied. 14. `@typescript-eslint/no-explicit-any` - used be 'warn', now 'error' 15. `@typescript-eslint/no-inferrable-types` - used to be 'error', now it's no longer applied. 16. `no-loss-of-precision` - used be 'off', now 'error' 17. `@typescript-eslint/no-loss-of-precision` - used be 'error', now it's no longer applied. 18. `@typescript-eslint/no-non-null-assertion` - used be 'warn', now it's no longer applied. 19. `valid-typeof` - used be either 'error' or 'off', now always 'error' 20. `no-unused-expressions` - used be always 'error', now either 'error' or 'off' 21. `@typescript-eslint/prefer-function-type` - newly added as 'off' 22. `@typescript-eslint/no-require-imports` - newly added as 'off' 23. `@typescript-eslint/no-empty-object-type` - newly added as 'off' 24. `unicorn/template-indent` - newly added as 'off' 25. `@typescript-eslint/no-duplicate-enum-values` - newly added as 'error' 26. `@typescript-eslint/no-unsafe-declaration-merging` - newly added as 'error' 27. `@typescript-eslint/no-unsafe-function-type` - newly added as 'error' 28. `@typescript-eslint/no-unused-expressions` - newly added as 'error' 29. `@typescript-eslint/no-wrapper-object-types` - newly added as 'error' 30. `no-new-native-nonconstructor` - newly added as 'off'fix(deps): update typescript-eslint monorepo to v8 (major) (#11235) by @Josh-Walker-GM
Please see #11235 for more detailsfix(api-server): Use createServer in all cases, to make fastify config consistent (#11176) by @dac09
\[BREAKING] Removes serverConfig support, in favour of server file to configure your Fastify instance. You can still customise your server settings by running `yarn rw setup server-file` first. See docs for [Server File](https://docs.redwoodjs.com/docs/docker/#using-the-server-file) This PR removes all the cases where we use `createFastifyInstance` for the api server, and replaces it with `createServer`. This makes sure that the API server config is always consistent - whether you use a server file or not.fix(deps): update dependency resend to v3 (#11040) by @Josh-Walker-GM
Please see #11040 for more detailsbreaking: remove webpack (#10867) by @Josh-Walker-GM
This PR removes support for webpack. There are a number of breaking changes associated with removing a core component of previous versions. A list of such changes is: 1. `prebuildWebFile` is function no longer exported from `@redwoodjs/babel-config` package 2. `@redwoodjs/cli-storybook` has been removed 3. `yarn rw build` no longer accepts the `--stats` flag 4. `yarn rw dev` no longer accepts the `--watchNodeModules` flag 5. `yarn rw setup custom-web-index` command has been removed 6. `yarn rw setup webpack` has been removed 7. `@redwoodjs/core` no longer provides `@redwoodjs/core/config/*` files 8. The `web.bundler` TOML config option has been removed 9. `@redwoodjs/testing` no longer provides storybook config files 10. `@redwoodjs/testing` no longer provides a `StorybookProvider` 11. The `webpack` bin has been removed from `@redwoodjs/web` You can also find more information on the upgrade guide.feat(colors): Add more chalk colors. And prepare for chalk upgrade (#10939) by @Tobbe
Add more colors to `@redwoodjs/cli-helpers`. Breaking: No longer exporting `green` as a color. Use `tip` or `success` instead depending on what you want to convey.remove(cli): Remove deprecated deploy providers (#10859) by @Josh-Walker-GM
This change removes the deprecated deploy providers edgio and ~~serverless~~. Serverless has been restored and is available in v8.chore(codemods): Remove pre v1 related content (#10831) by @Josh-Walker-GM
Please see #10831 for more detailsfix(deps): update dependency firebase-admin to v12 (#10833) by @renovate
This change updates our firebase auth provider to use the v12 major version of the `firebase-admin` package. This will require you to update your own version of `firebase-admin` that is listed in your api side package json file. We have noticed no breaking api changes in our limited testing. Please consult the `firebase-admin` upgrade guide if you experience problems after upgrading - especially if you have more extensive or complex use of the firebase suite of products.fix(functions-test): Fix mockHttpEvent for null bodies (#10570) by @Tobbe
With an empty/null payload (which it is by default) the body should be empty, not the string `'null'` This is a breaking change for anyone who was depending on the current "null" behavior in their api function tests. More specifically, if you're **NOT** passing `body` or `payload` to `mockHttpEvent({ ... })` or if you're trying to explicitly set `payload` to `null` you might have to update your tests.feat: Remove `--performance` option from `yarn rw build` (#10453) by @Josh-Walker-GM
This change removes the `--performance` flag from the `yarn rw build` command. It will no longer be available to use and the CLI will no longer accept this flag being passed in. Additionally, the associated webpack config (`@redwoodjs/core/config/webpack.perf.js`) has been removed so it can no longer be imported if you were doing so.fix(router): Remove barrel exports from router.tsx (#10464) by @Tobbe
We were using both `index.ts` and `router.tsx` as barrel export files. We should move away from barrel exports at some point, and we definitely don't need two files doing it in the same package. Everything that was exported from `router.tsx` is already exported by other files (except `Router` itself). So I updated the code to import from there directly instead. This is a breaking change for anyone who does `import ... from '@redwoodjs/router/dist/router'` in their project. Which hopefully isn't very many. - The quick fix is to find the original export and pull from there instead - The real fix is to talk to us on the core team and see if we can provide an official way of solving it instead of relying on internal implementation details 🙂chore(linting): Update versions and avoid `{}` (#10266) by @Josh-Walker-GM
This PR updates the versions of the `eslint` and the `@typescript-eslint` packages from v5 to v7. This is a major upgrade of the `@typescript-eslint` package and although we think it is unlikely to introduce a breaking change for you we would recommend that you read the associated documentation. The v6 upgrade can be found [here](https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/) and the v7 one [here](https://typescript-eslint.io/blog/announcing-typescript-eslint-v7/).fix(navlink): Replace (don't merge) className of active link (#10342) by @Tobbe
We should be replacing className with `activeClassName` for the active link. Currently we try to merge them, but that makes it very difficult for end users to have full control over exactly what classes are applied to active links Fixes [https://github.com/redwoodjs/redwood/issues/10296](https://redirect.github.com/redwoodjs/redwood/issues/10296) ##### Before ```tsxfeat(vite): upgrade to v5 (#10197) by @jtoar
Please see #10197 for more detailsfeat(prettier) upgrade to prettier v3 (#10179) by @jtoar
This PR upgrades Redwood internally to Prettier v3. We believe this won't have any downstream effect for users. If you have Tailwind CSS configured, can upgrade `prettier-plugin-tailwindcss` to a version later than `0.4.1` if you make a few changes: - Change `prettier.config.js` to `prettier.config.mjs` (js -> mjs) - `export default` instead of `module.exports` - `await import('...')` any plugins instead of `require('...')` Here's an example of an updated `prettier.config.mjs` to work with `prettier-plugin-tailwindcss@^0.5.12`: ```js // prettier.config.mjs export default { trailingComma: "es5", bracketSpacing: true, tabWidth: 2, semi: false, singleQuote: true, arrowParens: "always", overrides: [ { files: "Routes.*", options: { printWidth: 999, }, }, ], tailwindConfig: "./web/config/tailwind.config.js", plugins: [await import("prettier-plugin-tailwindcss")], }; ```RSC: createServerC