search

redwoodjs / redwood

The App Framework for Startups
https://redwoodjs.com
MIT License
17.31k stars 994 forks source link

Multiple RW apps all use the same debug port #10937

Open Tobbe opened 3 months ago

Tobbe commented 3 months ago

What's not working?

If you just try to simultaneously run two RW apps the second one won't start because the 8910 and 8911 ports are already taken. So you go and update your redwood.toml file to run your second app on 8912 and 8913. Now everything starts up just fine 🎉

The problem though is that they both launch with --debug-port 18911. That port should probably default to '1' + ${apiPort} to reduce the risk of conflicting ports.

I noticed this when running ps aux | grep rw-

First app, api side running on :8911 image

Second app, api side running on :8913 image

Notice how they both have the same debug port

How do we reproduce the bug?

See above. Run two RW apps at the same time.

Are you interested in working on this?

gracemorganmaxwell commented 3 months ago

I am keen to assist @Tobbe; I know exactly what you mean; I've experienced this behaviour before, when running two instances at the same time, usually because I forgot about the first one still be active.

I'm guessing the place to start a part from replicating the issue, is to find the file that controls that logic for the debug port and testing your theory out of 1 + ${apiport}.

callingmedic911 commented 2 months ago

First off, thanks for offering your help here @gracemorganmaxwell!

@Tobbe cmiiw, but similar to apiPort you can change debugPort in redwood.toml to a different value. However, we could have random port logic if there's no value set for any of the ports (api, debugger, others?). Though it would be a separate issue.