search

redwoodjs / redwood

The App Framework for Startups
https://redwoodjs.com
MIT License
17.28k stars 991 forks source link

green redwood dev favicon shows up in production #4698

Open thedavidprice opened 2 years ago

thedavidprice commented 2 years ago

The green favicon is meant to be local dev only — when deployed, the original red favicon should be used. However, on all my deployed projects I'm seeing green.

My guess is that we are using Node env = production as the logic switch, which likely won't work because often build environments use development.

Adding to the DX project board for next week

Tobbe commented 2 years ago

We decided this is the intended behavior, right?

thedavidprice commented 2 years ago

I believe so. I could have sworn we intended this for local-dev only.

Want to confirm @mojombo recalls the same --> i.e. the green favicon is currently used for local-dev and deployment; when we said "go for it", is that what you understood it was going to do? Either way, is behavior ok or should it be changed?

dthyresson commented 2 years ago

I confirmed with @orta that the purpose was to use this in dev and also have to get deployed.

Having it be green should warn you to update it to your application’s custom favicon — and also helps distinguish it from Redwood docs and other organization-related sites.

I believe this issue can be closed.

thedavidprice commented 2 years ago

Understood. I just want to make sure that was @mojombo's understanding when he made the decision.

Either way, likely not actionable at this time.