search

redwoodjs / redwoodjs-com-archive

Public website for RedwoodJS
https://redwoodjs.com
129 stars 156 forks source link

Motion Framer added #1023

Open miguelgargallo opened 2 years ago

miguelgargallo commented 2 years ago

🚨 HEADS UP

In preparation for the 1.0.0 release, the Redwood Docs have been integrated with the main Redwood Framework redwoodjs/redwood repo. We are in the final stages of the migration. Once complete, this repo will be archived.

Please do not open new PRs here. Instead, open them at https://github.com/redwoodjs/redwood/pulls

The new doc site uses Docusaurus. The Docs are located here:

ahaywood commented 2 years ago

I stumbled upon this PR because any storybook story with Framer Motion is breaking my Storybook build.

If I launch Storybook without the story and then add it, it doesn't have any trouble. But, if I create the story and then build it, it breaks.

This is the only other seemingly related issue I've been able to find so far: https://stackoverflow.com/questions/72710138/framer-motion-with-storybook-error-in-build-environment

Happy to provide additional information if needed.

miguelgargallo commented 2 years ago

I stumbled upon this PR because any storybook story with Framer Motion is breaking my Storybook build.

If I launch Storybook without the story and then add it, it doesn't have any trouble. But, if I create the story and then build it, it breaks.

This is the only other seemingly related issue I've been able to find so far: https://stackoverflow.com/questions/72710138/framer-motion-with-storybook-error-in-build-environment

Happy to provide additional information if needed.

I think I might find something useful, https://blog.sethcorker.com/scroll-animation-with-framer-motion/ from here's an example https://framer-motion-stories.sethcorker.com/?path=/story/framer-motion-scroll--letter

ahaywood commented 2 years ago

Thanks for sharing that link... and it does prove that Storybook and framer-motion can co-exist, but I believe something else is going on...

I found a couple of other issues with framer-motion: https://github.com/framer/motion/issues/1504 and https://github.com/framer/motion/issues/1447

In fact, locking into 6.2.4 resolved the issue for me, but that's a full version behind what's currently available. 😞

miguelgargallo commented 2 years ago

Yeah! That's why I am currently integrating on it, it would be awesome some day to use it! Let's go RedwoodJS Team!!!

And of course I will take a look into https://github.com/framer/motion/issues/1504 and https://github.com/framer/motion/issues/1447