search

redwoodjs / redwoodjs-com-archive

Public website for RedwoodJS
https://redwoodjs.com
129 stars 156 forks source link

Update Docs for Render Deploy to match the cli #954

Closed jacebenson closed 2 years ago

jacebenson commented 2 years ago

I was wrking on trying out Render today and I was following the yarn rw setup deploy step for render regarding database selection.

I got the following error. image

Invalid values:
  Argument: database, Given: "postgres", Choices: "none", "postgresql", "sqlite"

The docs say you can use postgres here: https://redwoodjs.com/docs/deploy#render-tldr-deploy. But the CLI says its needs to be postgresql

Should just be a typo fix: https://github.com/redwoodjs/redwoodjs.com/blob/main/docs/deploy.md?plain=1#L104

simoncrypta commented 2 years ago

Hi @jacebenson ! Do you think we should update the doc, or we should update the CLI? I'm not the best in naming, but I'm always in the clan of shorter is better for CLI 😛.

Also, I think you merged the PR into your own fork. Can you retry from your main branch to the redwood repo?

jacebenson commented 2 years ago

Hey, @simoncrypta I'm not sure where the right place should be or if maybe we allow for both? But it should be consistent.

I figured the least amount of work would be just to update the docs.

I'll retry my PR, I am not sure why or what I was doing.

If we need to update the CLI to match then the docs are right.