search

redwoodjs / redwoodjs.com

redwoodjs.com redesign for 1.0
21 stars 22 forks source link

Footer accessibility fixes #75

Closed jacobarriola closed 2 years ago

jacobarriola commented 2 years ago

Summary

This MR intends to fix an accessibility issue in the footer. We are violating https://dequeuniversity.com/rules/axe/4.4/list, where a <ul> must only directly contain a <li> element.

Currently, the social elements directly contains a div, which violates this rule.

This also fixes an import typo, which breaks storybook when first launched.

Related Issue

https://github.com/redwoodjs/sprout/issues/45

netlify[bot] commented 2 years ago

Deploy Preview for redwood-sprout ready!

Name Link
Latest commit 85b34066f326307c87f5838dc857d174e98e884a
Latest deploy log https://app.netlify.com/sites/redwood-sprout/deploys/62798cb8f8e6c00008244422
Deploy Preview https://deploy-preview-75--redwood-sprout.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jacobarriola commented 2 years ago

Awesome! Thanks for the merge! 💯