search

redxtech / vue-plyr

A Vue component for the plyr (https://github.com/sampotts/plyr) video & audio player.
Other
771 stars 137 forks source link

Add UMD bundle #1

Closed egoist closed 6 years ago

egoist commented 6 years ago

Currently you only have CommonJS bundle which can't be used in browser directly.

https://github.com/redxtech/vue-plyr/blob/7a7d9f0f7cefb0a8f6f43221a62350ef375e4ccb/poi.config.js#L4

poi build --library && poi build --library VuePlyr would fix it, in this case you should remove removeDist: true

redxtech commented 6 years ago

Oh shoot. Thanks @egoist , I forgot about that. However, when attempting to do this i only end up with one file. Is there a way to avoid this? And also, would it be better to use bili to output each module with one command?

egoist commented 6 years ago

there's always an option https://poi.js.org/#/options?id=filename

redxtech commented 6 years ago

@egoist added a UMD bundle and switched to bili for cleaner bundling. It's been working really well \:) Thanks for reminding me to add this