search

redxtech / vue-plyr

A Vue component for the plyr (https://github.com/sampotts/plyr) video & audio player.
Other
770 stars 136 forks source link

version 7 not working correctly from cdn #257

Closed praine closed 3 years ago

praine commented 3 years ago

The new version 7 of vue-plyr no longer initializes correctly when included from CDN:

"Unknown custom element: - did you register the component correctly?"

redxtech commented 3 years ago

That change is reflected in the README. Also v7 is not yet fully released.

praine commented 3 years ago

sorry, i tried reverting to the previous version but I'm still getting the same issue.. could you advise? It was working fine until today.

redxtech commented 3 years ago

Previous versions worked fine, check examples folders in older commits. Also, I published v7 beta today, so that's why.

praine commented 3 years ago

ok, i downloaded previous version from cdnjs. can I ask why the change with the initialization?

redxtech commented 3 years ago

The old method didn't work with vue 3.

praine commented 3 years ago

OK, thanks.

On Mon, 2 Nov 2020 at 20:47, Gabe Dunn notifications@github.com wrote:

The old method didn't work with vue 3.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/redxtech/vue-plyr/issues/257#issuecomment-720423032, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQCDZJYQ6IH6OC4ODNRZ5DSN2L3VANCNFSM4THLG4UQ .