search

redxtech / vue-plyr

A Vue component for the plyr (https://github.com/sampotts/plyr) video & audio player.
Other
768 stars 136 forks source link

https://vimeo.com/api/v2/video/{id}.json not found #358

Open pjatx opened 3 years ago

pjatx commented 3 years ago

Found a bug that seems to be inherited from earlier versios of plyr - wondering why it still seems to show up here?

https://github.com/sampotts/plyr/issues/1181

Would be awesome if we could grab the changes from this PR into this library as well: https://github.com/sampotts/plyr/commit/5d2c288721bd8d7be77352cf1f8f81c2592aeed5

jeffreykthomas commented 3 years ago

I also am experiencing that bug, video isn't playing anymore...

pjatx commented 3 years ago

@jeffreykthomas I tried patching it myself, but couldn't quite get it to work - if you find a better library or workaround lmk!

meuhland commented 3 years ago

@pjatx & @jeffreykthomas You can look into the fork I did of the repo here https://github.com/meuhland/vue-plyr you can install it straight from GitHub using npm it's built against the latest sampotts/plyr version.

If need be I can look into pushing to npm to help you... (Not looking into taking over maintaining... just did the work and willing to share!)

pjatx commented 3 years ago

Legend, thanks so much @meuhland! No expectations attached : )

pjatx commented 3 years ago

@meuhland heads up the css is breaking per https://github.com/redxtech/vue-plyr/issues/359. Going to implement this solution, but may also fork your fork and fix

meuhland commented 3 years ago

@pjatx If you're still having the CSS issue I can have a quick look and add the workaround in my fork it shouldn't be too long.

pjatx commented 3 years ago

@meuhland I actually just implemented the workaround here, so no worries!

https://github.com/redxtech/vue-plyr/issues/359#issuecomment-827690577