redxzeta / color-box

https://fun-color-box.netlify.app/
MIT License
1 stars 2 forks source link

Change a row or column colors #1

Closed redxzeta closed 3 years ago

redxzeta commented 3 years ago

implement a way to change an entire row or column random colors

gamer-1478 commented 3 years ago

Hello sir, i had a few questions about this issue, so firstly how would you like to change the entire row to random colors? like should a button be added or such? or should clicking the top color change all the colors in the row? also could be possible for you to explain what the app does and perhaps add it in readme.md? as that may be very helpful. but overall i would like to work on this issue.

redxzeta commented 3 years ago

Each box has data

interface IColorBox {
  id: number;
  top: number;
  left: number;
  right: number;
  bottom: number;
  color: string;
}

I guess either do a while loop or something until the it reaches the end which would hold -1

maybe a button at the ends of the row or columns which would trigger color changes

redxzeta commented 3 years ago

I think u maybe have to fix the styling so probably add like a container

gamer-1478 commented 3 years ago

Good Evening sir, when i sat down to add the features i soon realized that with the current code it will not be possible to implement them without completely refactoring the project structure, and most of the code, and that is not feasible for me just yet as i am still learning and understanding. so seeing this i have unassigned myself from this project. Loved the app, and hopefully someone else can contribute.

redxzeta commented 3 years ago

@gamer-1478 its okay I can help out if u want

mankinchi commented 3 years ago

I can work on this

mankinchi commented 3 years ago

But I think this should be fixed first https://github.com/redxzeta/color-box/issues/4. I can work on that one too if you want

redxzeta commented 3 years ago

@mankinchi did you still want to work on this?

mankinchi commented 3 years ago

Sure. Assign me this

Kind regards, Tri Nguyen

IT Consultant | Unified Commerce

Level 9, 800 Collins Street, Docklands, VIC 3008

M: 0449 258 526 ( tel:0449%20258%20526 ) | @.***

On Fri, 08 Oct 2021 at 1:52 am Nathan < Nathan ( Nathan @.***> ) > wrote:

@mankinchi ( https://github.com/mankinchi ) did you still want to work on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/redxzeta/color-box/issues/1#issuecomment-937870445 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AB6JFXYWDEIVUTYQ2EBCU73UFWX4HANCNFSM5FCPHMYA ). Triage notifications on the go with GitHub Mobile for iOS ( https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 ) or Android ( https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub ).

mankinchi commented 3 years ago

@redxzeta so how do you want to do this? Does this include clicking on a box should change everything on its column and row?

redxzeta commented 3 years ago

@mankinchi yea I was thinking maybe double click or right click wou8ld change the column and row