search

reearth / resium

React components for 🌏 Cesium
https://resium.reearth.io
MIT License
746 stars 135 forks source link

Export Component Prop Types for Extensibility #676

Closed reggie3-braingu closed 1 month ago

reggie3-braingu commented 1 month ago

Issue

Current, not all component props definitions are exported for use by applications incorporating this package. For example, the type for KMLDataSourceProps is not exported in a way that makes it available for extension by another component. Attempting to use the definition results in the following error:

image

Attempting to import the definition results in this error:

image

Proposed Solution

Export type definitions so that they can be used by applications incorporating this library.

Implementation

Is there any guidance for submitting an PR to resolve this issue. I'm willing to create and submit one myself; however, I'd like to know of any guidance or potential pitfalls related to this issue.

reggie3-braingu commented 1 month ago

Hi @keiya01. I've attached a PR to fix this issue. Please let me know if you have an comments or changes.

reggie3-braingu commented 1 month ago

Thank you @keiya01 !