search

reecelucas / react-datepicker

An accessible, internationalizable React datepicker
MIT License
12 stars 6 forks source link

tab and roles #7

Open jonasdd opened 4 years ago

jonasdd commented 4 years ago

Hi. Great work ! Not much is missing to make it fully accessible. Have you considered adding a dialog role on the date picker container like suggested on wai-aria design pattern ? With the dialog role, tablation should be contained inside the dialog itself. Also The date table should have a grid role to make it more relevant to navigate with arrows.

reecelucas commented 4 years ago

Hi @jonasdd, those changes make sense. Are you happy to raise a PR?