search

reecetech / pactman

Pact management (mocking, generation and verification)
Other
91 stars 37 forks source link

Using query on DELETE requests in pact_verifier #94

Open MazeDeveloper opened 4 years ago

MazeDeveloper commented 4 years ago

I implement provider tests for an API using QueryStrings on DELETE http method. The requests library would support that and I locally test that it would work when adding the use of query from the pact.json in the service_DELETE function like for e.g. in the service_GET function in the Interaction class of verify.py.

Is there a reason it is not supported? As far as I know it is correct to use QueryStrings on DELETE http method.

r1chardj0n3s commented 4 years ago

This is an oversight, I can't think of a reason to disallow query parameters in a DELETE.

MazeDeveloper commented 4 years ago

I fixed the issue locally in a feature branch but I am not able to push it. Can I get permissions or how is that working? I followed the contributing.md. Alternatively would you fix the bug and I create a fork till fixed if it takes multiple day, so my team can continue? I don't want to bother you.

r1chardj0n3s commented 4 years ago

The way you can contribute is by opening a Pull Request against the project. The info about this is here: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Let me know if you need any further assistance!