reed-college / paneity

The state of being bread.
2 stars 0 forks source link

Fix eslint issue in inbox.js #273

Closed grantal closed 7 years ago

grantal commented 7 years ago

There is some code in inbox.js the errored with the eslint rule 'no-await-in-loop', so I turned that rule off. I would like to turn this rule back on and restructure the code so it doesn't get this error

grantal commented 7 years ago

I think that the rule should be suppressed in this case. Here is the offending code for reference. The point of the rule is so that the loop can continue while the asynchronous function is running. But, in our case the asynchronous function is supposed to make the loop stop for a second so that the title of the page flashes intermittently. This is completely contrary to the rule, so the rule must be suppressed