search

reed / turbolinks-compatibility

A collection of tutorials for how to get your favorite javascript libraries, plugins, and snippets working with Turbolinks.
reed.github.io/turbolinks-compatibility
MIT License
147 stars 35 forks source link

Google Adsense over https #15

Open harmdewit opened 11 years ago

harmdewit commented 11 years ago

The solution illustrated here works great, but not for pages over https. I'm getting the following error:

[blocked] The page at https://domain.com ran insecure content from http://googleads.g.doubleclick.net/pagead/ads?client=ca-pub-331342934991185…680&u_cd=24&u_nplug=9&u_nmime=64&biw=1680&bih=469&fu=0&js=uds&eid=37464000.

I understand from this post that AdSense over https is fairly new.

I tried to find any documentation on the javascript AdSense API but with no succes. Is there even an official javascript AdSense API?

reed commented 11 years ago

If you change this:

<script src="//www.google.com/jsapi"></script>

to this:

<script src="https://www.google.com/jsapi"></script>

Does it work?

harmdewit commented 11 years ago

Unfortunately no, the page still loads the an insecure iframe from a source without https.

reed commented 11 years ago

Hey @guangnan, do you have any insight on this?

chengguangnan commented 11 years ago

Sorry. I have no idea.

jgeggatt commented 10 years ago

It doesn't look like there's been any movement on this issue recently, but I would love to try to help find a solution. We are currently having the unfortunate discussion of disabling Turbolinks altogether since we can find no other way around this issue. I have spent some time researching, but have been unable to find any sort of documentation on the Google "Ads" API. I'm thinking there has to be some way to tell it to load a secure ad, either via an options parameter or perhaps by overwriting some loader code. So my question is, what were you guys working off of when you built this code? Any sort of API documentation that exists out there, or was this proprietary knowledge of Google's (publically unsupported) Ads API?

harmdewit commented 10 years ago

Unfortunately we did not find a solution and decided to disable Turbolinks. I believe all ads were loading on first visit, but subsequent pages loaded irregularly. Sometimes some ads loaded, sometimes they didn't.

The last thing i can remember is that we didn't have control over our AdWords account and that we were probably using a third party provider besides Google. Maybe they only partially supported loading ads over SSL. Due to time constraints we chose the easy way and dropped Turbolinks sacrificing our loading speed.

jgeggatt commented 10 years ago

@harmdewit that is sad to hear and I'm hoping it doesn't come to that for our project as well. Really, this should be a simple problem to solve (on Google's end) but it doesn't seem that they have any intentions of making this API "supported" any time soon. But then again, I can't find any real mention of this functionality on their site or elsewhere, so maybe I am just looking in the wrong places.

Also, this isn't an issue of AdSense not supporting ads over SSL - they do it as expected when displaying the ads in the suggested manner (ie, without turbolinks). So it is just a bug in the jsapi that is causing the ad to load insecurely.

pratap224 commented 9 years ago

hai please help me i am facing problem with turbolinks it is not allowing my ads i followed this link but no use please help me https://github.com/rails/turbolinks/issues/151