search

reedessick / universality

an investigation into the application of universal, EOS-independent relations in Gravitational Wave astronomy
MIT License
3 stars 2 forks source link

Account for zero-weight corner case in entropy #38

Closed isaaclegred closed 1 year ago

isaaclegred commented 1 year ago

This is just a little problem I've run into, would be nice to have this in master

reedessick commented 1 year ago

Hi @isaaclegred,

Could you please clarify the use case for this change? It seems to support the case where every weight in a distribution is exactly zero, which shouldn't happen.

I would worry that this case should raise an exception rather than silently return zero. Thoughts?

isaaclegred commented 1 year ago

Hm yeah that's true, I think I've identified the actual issue, closing this PR