search

reedsy / quill-cursors

A multi cursor module for Quill text editor.
MIT License
250 stars 53 forks source link

Remove engines from the dependency requirements #10

Closed sroze closed 6 years ago

sroze commented 6 years ago

Using Node 9.x is perfectly fine for example. As I don't see any value of having such thing in the dependencies, I propose to remove them :)

alecgibson commented 6 years ago

I honestly don't know much about this repo. If it doesn't use any of Node's libraries, then it's probably fine. If it does use Node libraries, then a major version change could actually be breaking, and it would be good practice to record the version against which it was designed/built/tested.

As I said, though, I have zero context on this repo, and no strong opinions, so if this is genuinely blocking, go ahead and remove it.

pedrosanta commented 6 years ago

This lib doesn't use any Node libraries, so no harm from there. Perhaps it would be more appropriate to have the engines as such:

"engines": {
  "node": ">8",
  "npm": ">5"
},

But as @sroze said, this doesn't bring much value at this point, so lets remove. Thank you for comments and PR! 🙌

pedrosanta commented 6 years ago

@sroze Just published v1.0.3 with this removed, FYI.

sroze commented 6 years ago

Great, thank you! On Wed, 11 Apr 2018 at 16:47, Pedro Machado Santa notifications@github.com wrote:

@sroze https://github.com/sroze Just published v1.0.3 https://github.com/reedsy/quill-cursors/releases/tag/v1.0.3 with this removed, FYI.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/reedsy/quill-cursors/pull/10#issuecomment-380500878, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxHEQrivuOMWlBg1g_SlvipRoHFPx1bks5tniV8gaJpZM4TP0bj .