fix issue with pca9685 100% output. fixes #18

reef-pi / drivers

Various sensors, controller and IC drivers for reef-pi

Other

5 stars 17 forks source link

fix issue with pca9685 100% output. fixes #18 #19

Closed Ranthalion closed 5 years ago

Ranthalion commented 5 years ago

Uses special control bits to set pwm channel to 100% and 0%.

I couldn't see a reasonable way to write a unit test to make sure the pca9685 driver is called with the appropriate values, but I'm definitely open to feedback. Functionality was manually tested and confirmed on pi 3 hardware.

ranjib commented 5 years ago

@Ranthalion did you test this on actual hardware?

Ranthalion commented 5 years ago

@ranjib Code fix was tested on actual hardware. Pi3 was used with my v2 reef-pi hat and test fixture. Confirmed that previous version turned the LED off at 100%, new version turns on the led appropriately.