search

reehan79 / openjpeg

Automatically exported from code.google.com/p/openjpeg
0 stars 0 forks source link

remove all printf from openjpeg / use proper function pointer for logging #371

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The only decent log library for c seems to be zlog

http://hardysimpson.github.io/zlog/

But it is posix only. We would need to do a windows port.
In the meantime, we could probably use the same interface 
and just output to printf for windows.

Original issue reported on code.google.com by boxe...@gmail.com on 5 Jul 2014 at 2:10

GoogleCodeExporter commented 9 years ago 
no external dep for such a low level implementation. opj mecanism allows one to 
use any 3rd party log lib. closing as wontfix.

Original comment by mathieu.malaterre on 17 Sep 2014 at 9:58

GoogleCodeExporter commented 9 years ago 
I still see printf statements in the code. Does the opj mechanism redirect 
printf to user-defined output? If not, I think we should convert all printf 
statements to use the opj handler, in order to be consistent.

Original comment by boxe...@gmail.com on 17 Sep 2014 at 2:27

GoogleCodeExporter commented 9 years ago 
agreed. I thought all printf(s) were removed in 1.x -> 2.x transition. Please 
report here if you find one. thx.

Original comment by mathieu.malaterre on 17 Sep 2014 at 2:29

GoogleCodeExporter commented 9 years ago 
Most annoying are the fprintf's in t2.c (some of which still have a commented 
out opj_event_msg call right beside them) and the three WARNING fprintf's in 
tcd.c and tgt.c which regulary spam my console.

Original comment by zeniko on 30 Oct 2014 at 7:43