search

reek / anti-adblock-killer

Anti-Adblock Killer helps you keep your Ad-Blocker active, when you visit a website and it asks you to disable.
http://reek.github.io/anti-adblock-killer/
Other
6.01k stars 760 forks source link

9.8 vs 9.9 #2376

Open Martii opened 8 years ago

Martii commented 8 years ago

So was just perusing and noticed that 9.9 is here with c0cfd48e215f2886a4487190131349eb29058fbf but on OUJS it's 9.8.

Retested the webhook and it appears solid with https://github.com/Martii/UserScripts/commit/8dd983d179ce3419b34ed458796eb14dbecf3b16

Was wondering if this was intentional since the time stamps are further apart on your update on OUJS.

Thanks, OUJS Admin

reek commented 8 years ago

HI,

The update should have been done on OUJS,

I revalidated the webhook, it's good now, but I will check if this happens again next time

Thank you for reporting

reek commented 8 years ago

This failed again with v10.0 https://github.com/reek/anti-adblock-killer/commit/9a933f417f0fd074935b23ef2d8ad0fa0c62631c

Martii commented 7 years ago

Okay so, as you, I reimported this script into OUJS... that should reinitialize everything on our end. What I need you to do is check your GH log and see if the notice was pushed ~23 hours ago. Also double check that the webhook is setup as described in the third column of https://openuserjs.org/user/add/scripts ... this is located near https://github.com/reek/anti-adblock-killer/settings/hooks with the Edit button (scroll to deliveries and also confirm settings... we don't support secrets btw) . Anything extra please tell me about. It worked for me so something is awry.

As I did before I also tested my webhook to see if it's working and you can see by the commit reference I put it is.

reek commented 7 years ago

If you want the contents of the payload, contact me using http://reek.github.io/anti-adblock-killer/#contact

Martii commented 7 years ago

Delivered at 2016-11-17 04:07:13 response 200

Your commit is dated 2016-11-17T03:01:47Z and taking ~6 minutes to travel from GH to OUJS isn't right.

http://reek.github.io/anti-adblock-killer/#contact

error ... doesn't appear to work...

Martii commented 7 years ago

So the reason the delivery json dump you sent me is getting ignored is in the section of your event of:

"ref": "refs/tags/v10.0",

and our code at https://github.com/OpenUserJs/OpenUserJS.org/blob/98c5b3f1ddbff33e2ab7e11052d97b894e4d1946/controllers/scriptStorage.js#L1050-L1053

This is also why mine is getting through because mine matches this conditional. If you can add your tags after you commit to master that should work... does here. I'll see if there's a different way when I'm more alert. ZZzz...

reek commented 7 years ago

Ok, thanks

Martii commented 7 years ago

So I added some http status codes into OUJS to indicate more useful responses here on GH. e.g. if you have the tag pushed to GH we'll still reject it but at least you will know by the status codes depending on the failure. I did a test where I went ahead and tagged before a push to GH... and OUJS rejected it... so then I had to push master and that's when it was processed... so this is the current procedure if you want tags forced to GH... or you can add them after you push to GH master.

I don't see anything in the delivery packet that allows us to get the abbreviated reference name of a tree_id e.g. the equivalent of git rev-parse --abbrev-ref HEAD so that tags may be sent in the ref property and processed instead of being dropped. If you, or anyone, else figures that out it might be useful for those using tags to only have to push once... the github dependency is still too volatile to see if we can call GH and figure out if the id of the tree name is the "master" or not... I'll keep it in mind when that day comes.