search

reenhanced / gitreflow

Reflow automatically creates pull requests, ensures the code review is approved, and squash merges finished branches to master with a great commit message template.
MIT License
1.49k stars 64 forks source link

modernize gem structure; Fixes #158 #159

Closed pboling closed 8 years ago

pboling commented 8 years ago

Fixes #158

codenamev commented 8 years ago

I must admit I'm not a fan of bundler's move to the new exe executable file pattern as it conflicts with rubygems standardized patterns. We are using bundler though so we might as well update it.

:+1: once those comments are yanked. Thanks for the contribution :smile:.

codenamev commented 8 years ago

modernize gem structure

pboling commented 8 years ago

The bin/console tool is super useful for playing with the gem's code, that was the driver for the change. And it shouldn't be released with the gem. It is unfortunate that the RubyGems guide and the bundler pattern are out of sync 😢

pboling commented 8 years ago

@codenamev comments removed.

codenamev commented 8 years ago

Yeah bin/console is really neat. I came across this in the reality gem not too long ago and really liked it.

LGTM, nice work!