[Issue #141] Fixing Issues and Adding Configurable Nx LGTM and LGTM Regex Options, Adding Rspec Tests

[simonzhu24]

1. Adding 2x LGTM and last comment must be LGTM option
2. Made configurable number of LGTM options vs "all-reviewers-must-approve" option in "~/.gitconfig.reflow" and "setup.rb"
3. Made LGTM Regex Expression configuration in ~/.gitconfig.reflow and "setup.rb"
4. Added Rspec tests to cover both options, checking for correct pull_request.build.target_url values as well
5. Added Rspec tests to check for different LGTM expressions (found and fixed bug)

[pboling]

LGTM 👍

[codenamev]

Really great work here @pboling! I really like the configuration chooser at setup :smile:

[pboling]

Regarding the spec syntax update, transpec can do the update automatically IIRC.

[codenamev]

@pboling great idea. I've created a separate task to address that to keep the changes here smaller. Also, I appologize to @simonzhu24 for giving @pboling credit for this! My activity feed made it seem like he was the author. Thank you so much @simonzhu24 for your effort here :smile:

[pboling]

@simonzhu24 has been the primary author here, I've just been giving him a lot of feedback, as we sit next to each other in the office. 👍

[codenamev]

[Issue #141] Add Configurable Nx LGTM and LGTM Regex Options

[pboling]

In that case the logic should be defined by pseudo-code in the parent class, and the implementation methods should raise an error and be defined in the child classes.

[codenamev]

Address those comments and I'm good with this :smile: Nice work @simonzhu24!

[codenamev]

LGTM :tada: :100: :rocket:

Will merge once CI comes back green :smile: Thank you again for all the hard work here @simonzhu24!

[pboling]

Fantastic!