search

reenhanced / gitreflow

Reflow automatically creates pull requests, ensures the code review is approved, and squash merges finished branches to master with a great commit message template.
MIT License
1.49k stars 64 forks source link

Upgrade RSpec #162

Closed codenamev closed 8 years ago

codenamev commented 8 years ago

As @pboling has pointed out, we can use the transpec gem to do a lot of automated translations to the new allow syntax.

simonzhu24 commented 8 years ago

Ready for a PR =)

simonzhu24 commented 8 years ago

@codenamev I think we can close this issue now.

codenamev commented 8 years ago

I believe we still need to upgrade RSpec itself? @pboling should have details on the issues he faced. He locked us in at 3.0 in a previous PR, so I think we still need to do a bundle update rspec here and do some sanity checks on the specs.

codenamev commented 8 years ago

Upgrade RSpec

pboling commented 8 years ago

Actually I didn't lock to 3.0, I actually unlocked so we can upgrade.

Old version constraint was ~> 3.0.0, and I changed to ~> 3.0 meaning that with a simple bundle update rspec it will now install the latest 3.4 version, and put that in the Gemfile.lock. @simonzhu24 will you do that, and see if all the tests pass? There were so many failures before the syntax fix that I didn't bother to look at the causes.