search

reesef / php-twig

This is a conversion of Anomareh / PHP-Twig.tmbundle for atom
35 stars 19 forks source link

Package.loadSettings is deprecated. #27

Closed guilhermecvmnsj closed 9 years ago

guilhermecvmnsj commented 9 years ago

Store package settings files in the settings/ directory instead of scoped-properties/

Package.loadSettings (/usr/share/atom/resources/app.asar/src/package.js:584:9)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:184:43)
Package.measure (/usr/share/atom/resources/app.asar/src/package.js:163:15)
Package.load (/usr/share/atom/resources/app.asar/src/package.js:177:12)
PackageManager.loadPackage (/usr/share/atom/resources/app.asar/src/package-manager.js:355:14)
PackageManager.activatePackage (/usr/share/atom/resources/app.asar/src/package-manager.js:434:30)
samijnih commented 9 years ago

+1

StijnMaenhaut commented 9 years ago

+1

Blackcatz1911 commented 9 years ago

+1

leopoiroux commented 9 years ago

+1

wujku commented 9 years ago

+1

chrisramakers commented 9 years ago

Looks like this is already fixed in https://github.com/reesef/php-twig/commit/aa15cc521b27c06cbc6912d0ff7b9369e8bdfa09 but the release needs to be tagged in order to have the package updated on atom.io

wesleyahall commented 9 years ago

+1

hlecuyer commented 9 years ago

+1

jdsimcoe commented 9 years ago

:+1:

vitornogueira commented 9 years ago

+1

taeram commented 9 years ago

This seems to be the authoritative place for tracking Package.loadSettings is deprecated, as clicking Report Issue in Atom v0.201.0 now takes you directly here.

Duplicated by #17, #18, #19, #20, #22, #25 and #26.

JimmyMultani commented 9 years ago

@reesef Can you please update the package soon? All deprecated APIs are supposedly getting removed from Atom today. Thank you.

reesef commented 9 years ago

@JimmyMultani Sorry about that. Done.

JimmyMultani commented 9 years ago

@reesef Thank you! I think the release tag being versioned incorrectly is causing it to not update correctly in the Atom database. Can you rectify that please?

v4.-0.0 should be v4.0.0

Cangit commented 9 years ago

@reesef you publish packages on atom with the apm publish command, not by tagging a release in git(hub). Atom - publishing a package guide