search

reeseovine / pronouns.js

personal pronoun helper
GNU Affero General Public License v3.0
24 stars 3 forks source link

Use different example sentences #5

Open reeseovine opened 4 years ago

reeseovine commented 4 years ago

Finding a different set of sentences will help differentiate this module from pronoun.is. Also "Frisbee" is a trademark so we should avoid it.

Suggestions are welcome.

michaeljoelt commented 2 years ago

I haven't looked in to your code yet, but how are you storing these? Could each "sentence type" be broken up in to an array with multiple examples, and then a random example from each could be displayed each time? Like:

const sentenceSubject = ["They went to the park.","They danced the night away.","Did they finish the assignment?"]
const sentenceObject = ["I went with them.","I've been thinking about them.","I told them the plan."]
const sentenceDeterminer = ["They brought their football.","They rode their bike here.","Their haircut looks amazing!"]
const sentencePossessive = ["At least I think it was theirs.","Were these old shoes theirs?","Sorry, I didn't know this was theirs."]
const sentenceReflexive = ["They threw the football to themself.","Did they come up with that themself?","Did they make this by themself?"]

Also, the "Their haircut looks amazing" example made me think about how it would be awesome to try to include a bunch of compliments in these :D

reeseovine commented 2 years ago

@michaeljoelt that's a great suggestion! i'll look into it at some point.