search

reetmitra / pe

0 stars 0 forks source link

Name input does not check the type #3

Open reetmitra opened 5 months ago

reetmitra commented 5 months ago

Screenshot 2024-04-19 at 4.39.03 PM.png

I used the command add n/123 p/1234 and it added a person called 123. I think the name input should have the functionality to check that it only takes in letters?

nus-pe-bot commented 5 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid Names Can be Added

Description:

User can input names with only numbers, although names do not have numbers.

Steps to Reproduce:

  1. Enter the following command "add n/87456187 p/96740636"
  2. Hit Enter

Expected Behaviour: Error Message: Names cannot have numbers, please try again

Actual Behaviour: Program accepts and runs the command, creates a person with a number as a name

Screenshot/Video:

issue 1.png

Other Comments:

  • Assigned medium because it can affect other functionality within the program
  • It can also make the user confused between phone numbers and names, especially in the case of a typo

[original: nus-cs2103-AY2324S2/pe-interim#831] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We allow alphanumeric characters for contact names for flexibility of usage, for instance if the user wants to name their context alex1010. This is also stated in the UG.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I believe this would be a valid functionality to correct (even in the future), similar to the reasons given below.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I appreciate your well-detailed explanation, however, I believe this would be medium however because it could confuse a user between names and phone numbers in certain cases.