reettap / calculator

A calculator application for Tiralab course
0 stars 0 forks source link

Peer review #1

Open sampsaoinonen opened 1 month ago

sampsaoinonen commented 1 month ago

Peer Review

Project downloaded: 1.10 at 12.00


General Feedback:

Your project is well-structured and shows a good understanding of shunting yard algorithm with usage of tokenization, parsing, and evaluation. Code has been separated in a reasonable way into different classes. Basic funcitonality of the calculator seems to be working well. Unittesting has also been started.

Here are few of my suggestions for improvement.


Suggestions:

Tokenizer Class:

Evaluator Class:

CalculatorUI:

Unit Testing:

General Structure:


Overall:

Algorithm is understood, program is working, the code is well-organized and easy to follow. Keep up the good work!

reettap commented 1 month ago

Thank you for the extensive and detailed review!