reettap / calculator

A calculator application for Tiralab course
0 stars 0 forks source link

Peer Review #2

Open Sokirates opened 2 weeks ago

Sokirates commented 2 weeks ago

Peer Review

Project downloaded: 13.10 at 19:30

Initial Thoughts:

I do not personally know Java, and I was unable to run your project despite following the manual as instructed.

I received the following error message:

image

This error is most likely related to my machine setup, as this was the first time I installed Java 17 and Gradle.

General Feedback:

The code appears very clear, and it has been thoughtfully split into different files.

Although I don’t understand Java myself, the documentation makes it easy to follow what the code is supposed to do. For example, the Parser class has been documented very thoroughly.

Even though I wasn’t able to run the tests myself, looking at the test files, it’s clear that you’ve written a sufficient number of tests.

While this may not be strictly necessary for the course, I did find it a bit difficult to understand how the tests were constructed. Additional documentation for the tests could make it easier to comprehend.

reettap commented 2 weeks ago

Thank you for the review!

Indeed looks like a problem with your setup -- setting up a java dev environment is not the friendliest.

on the tests -- I see your point, I'll add more comments to clarify the purpose of the tests :)