reevoo / sapience-rb

Hasslefree auto-configuration for logging, metrics and exception collection.
MIT License
10 stars 0 forks source link

Fix naming inconsistency #2

Closed errm closed 8 years ago

reevoo-samuel commented 8 years ago

_If you're new, read the guidelines._

Good code is tested, designed for change, easy to understand and able to cope when things go wrong.

Good pull requests are descriptive, small and short-lived.

For the Author

For the Reviewer

errm commented 8 years ago

Also the github repo should be renamed, and the gem should be pushed to rubygems to sqaut the name.

reevoo-samuel commented 8 years ago

Er, hello?

This Pull Request is too damn old! Merge or close this, sucka.

reevoo-samuel commented 8 years ago

I don't see any comments on your Pull Request.

Are you too good for code reviews now? No. No you aren't.

Maybe you forgot to say who reviewed it. That's fine, but let me know.