search

reezer / tor-flashproxy-badge

[deprecated] small Firefox extension turning Firefox into a bridge for censored users in countries with oppressive regimes
https://addons.mozilla.org/en-us/firefox/addon/tor-flashproxy-badge/
29 stars 14 forks source link

Open the Flash proxy options #4

Closed bastik-1001 closed 11 years ago

bastik-1001 commented 11 years ago

(As it appears I can't label this as enhancement, nor can I select which version is affected, nor which component)

The version prior to version 0.1.0 allowed to view the http://crypto.stanford.edu/flashproxy/options.html page by clicking on the badge. Now this is not the case anymore.

I suggest the middle mouse button (since it won't be used most of the time and the user does not click it by accident) to open a new tab with the options. It was kind of useful to go to the page and disable the proxy.

For example your system is fetching updates and the proxy wouldn't provide any bandwidth.

Should this be to complicated/complex make it a "Wont fix/Invalid".

reezer commented 11 years ago

The badge is now independent of this page. However a way to still turn it off would be nice indeed.

bastik-1001 commented 11 years ago

"now independent" or do I misunderstand?

reezer commented 11 years ago

Uh right, fixed that. What I meant is that the original JS checks whether a cookie is set. I don't do that anymore, which means there Stanford server doesn't need to be contacted, but only the facilitator.

bastik-1001 commented 11 years ago

Alright, instead of opening a ticket for a question.... Does your add-on still set the cookie. (For me it is present, but I don't know if it survived or if your add-on set it)

In the case it does not set a cookie I'm opening a new ticket to request that. Your add-on is independent, but for me it's beneficial to opt-in, just in case the model switches to opt-in, and I would have to redo this every time I clear cookies.

reezer commented 11 years ago

No, it doesn't do the cookie stuff anymore. My earlier version did set it. Basically having this add-on activated is a way of opting in, don't you think so? So if you do not want that this stops working when you clear the cookies: It's already the case as long as you have this add-on activated, just because it does its job regardless of cookies. If you don't want this add-on to run you can simply disable it in the add-on manager.

bastik-1001 commented 11 years ago

Beside your add-on, which is wonderful and works as it should, I hope websites will include Flash proxy badges and if they choose the opt-in version of the system or the system itself turns opt-in I would have to enable (opt-in) every-time, not for your add-on, but for (all) the other websites.

If it is likely that your add-on gets settings, I'm going to request a) set cookie to opt-in (so your add-on is even more useful) b) a icon set for colorblind people. (I'm not colorblind myself, but learned that it sucks to be on TorTrac #7812)

If it doesn't or you find both unreasonable you won't get tickets for these.

reezer commented 11 years ago

About a) It doesn't seem to be really necessary. If you visit a website with the bade there won't be any difference, only that this connection will be more short-lived. You can have multiple connections even with one implementation, so there really isn't a benefit of both the add-on and an additional active badge, right? If you have the add-on it can do the job itself (doesn't need additional badges) and if you don't there will be no cookie set.

b) I agree. The icon is a quick thing. It actually would be cool, if someone would make a nicer icon. However the icon color reflects nothing that is not also seen by clicking on it. So that might be a solution for them. But again, I really think there should be a better icon in general, cause currently it doesn't really symbolize too much.

bastik-1001 commented 11 years ago

You won't get tickets for these.

a) I know that all proxies are working separate from each other and that the add-on works without the (additional) badge(s). There are already many users using the add-on or visiting a page with a badge on so you are probably right. There isn't really a benefit.

b) The reason for not creating a ticket is that you already said before that you would like your add-on to have different icons in general. You are also correct that people see the state of the add-on by clicking on the icon. Furthermore it's most likely to "just work".