So there are some sim tests that fail because of an assert_one_yocto. I didn't dig into it to see if it was a fault on the test or something changed internally or from an SDK fork that I'm not aware of.
Sorry for a large diff, I also formatted the files I touched
Possible inconsistencies:
AccountId is used sometimes when it probably shouldn't be (custom strings for nft token types) and String is sometimes used when it should be an AccountId. Now that AccountId is validated by default and on deserialization, you might want to audit these usages, because it's not just aliasing a string as before. AccountId has the same JSON serialization as ValidAccountId previously had.
If this or something similar comes in, can close #33
So there are some sim tests that fail because of an
assert_one_yocto. I didn't dig into it to see if it was a fault on the test or something changed internally or from an SDK fork that I'm not aware of.Sorry for a large diff, I also formatted the files I touched
Possible inconsistencies:
AccountIdis used sometimes when it probably shouldn't be (custom strings for nft token types) andStringis sometimes used when it should be anAccountId. Now thatAccountIdis validated by default and on deserialization, you might want to audit these usages, because it's not just aliasing a string as before.AccountIdhas the same JSON serialization asValidAccountIdpreviously had.If this or something similar comes in, can close #33