search

refact0r / system24

a tui-style discord theme
MIT License
1.07k stars 41 forks source link

Cut titles in WebCord #14

Open ejiektpobehuk opened 2 months ago

ejiektpobehuk commented 2 months ago

Thanks a lot for this gorgeous theme 😍 It rocks!

Unfortunately I can't experience is full glory because it has some problems rendering in WebCord. From the looks of things it's not a supported client, but I hope someone might have a better idea of fixing it than I do.

Some titles look just fine while others are cut.

Section Image
Activity image
Friends image
Channel image
DMs image
Servers image
Section Image
user image
server image
messages image
input image
members image

I suspected broken @input support but WebCord claims to have it fixed. Files with inputs populated by hand behave the same, so it's unlikely to be the reason. Custom theme support in WebCord is still experimental though.

I've got it working by running webcord --add-css-theme in terminal and selecting a *.theme.css. file. Disabled a theme by deleting it from {userData}]/WebCord/Themes which is in ~/.config for my linux system.

Testes with gruvbox and spotify-text.

ps. #11 mentions doubled left border of activities. This issue is also present here.

ejiektpobehuk commented 2 months ago

Found one other interesting thing. Input field.

For ReadOnly channels it looks almost OK except for the right margin: image

Writable one does something funky: image

refact0r commented 2 months ago

the cut off titles look like issues with overflow: hidden set on parent element. this might be because webcord has extra layers of html elements or something, idk.

it seems like making the theme work for webcord would require significant additional modification, so i don't intend to support it.

ejiektpobehuk commented 2 months ago

Thanks for a quick responce!

I suggest leaving an issue open for some time while I tinker with WebCord for a bit. There are two statemetns in Custom Style documentation that give me hope that compatability is not lost =]

WebCord is capable of styling Discord pages – unlike browser extensions like Stylus it does that without injecting any HTML elements to the page, to be more difficult to detect the modifications.

most themes, which does not rely on remote content like images and fonts, should be now mostly functional

F-Joubert commented 6 hours ago

This might be the same issue, I fixed something similar with sections cutting off here by adding some spacing: https://github.com/refact0r/system24/issues/48#issuecomment-2495677723