Closed d4c4nf3 closed 1 year ago
Hi @Vojislav-Cuk! Thank you! It looks like you put quite a bit of work into this! I'm currently working on converting the Maven plugin back into a MavenReport and upgrading the version of Doxia Site Renderer and related dependencies, but I think I can work around what you've done.
The pom.xml in the new report
module will need to be source/target Java 8 compatible to remain backwards compatible with Java 8 users. It still makes up probably 40% of the market at this time, and they're the users who could probably benefit from this tool the most. I'm not certain, but it's possible that the CLI version can remain at Java 17 and use Spring Boot 3.
Jim
Great. With this refactored it should not be hard to create CLI app now.
The pom.xml in the new report module will need to be source/target Java 8 compatible
This is something I wanted to ask. OK, I will change it to use java 8.
Do you have some idea how the CLI command should look like? The name of command and parameters?
Hi @Vojislav-Cuk,
I apologize for not getting back to you sooner - it's looking great!
As for the name: It might be a bit cheeky, but having the command as rf
would be memorable
I created it as refirst
with this usage
Usage: report [-d] [-b=rf
.
@jimbethancourt I have changed the command to rf
.
I also added reading project name and version from pom.xml file if those arguments are not already set.
During package stage, rf
sh script is created as executable jar. Parameters of rf
commands are the ones from my message above.
Closes #21 Refactor maven plugin module so that it only contains logic for maven plugin. Migrate code for generating reports to a separate module so it can be reused in maven/gradle plugins or CLI application.