search

refactoring-ai / Data-Collection

Collect refactorings with metrics from java source code.
MIT License
6 stars 1 forks source link

Feature/transaction per project more db connection options standalone importer. #21

Closed dvanderleij closed 4 years ago

dvanderleij commented 4 years ago

Hi all,

Here are some quality of life changes. i will push my test improvements in a different PR to keep them somewhat separated.

jan-gerling commented 4 years ago

Here are some quality of life changes. i will push my test improvements in a different PR to keep them somewhat separated.

Thanks for the PR, I have seen some good changes. I have a some remarks though:

  1. Could you please split this huge PR into multiple smaller ones, that are more concise? I find it impossible to assess the impacts of all changes together. Also for some of the changes, I am not sure how the would perform under high load or some other edge cases.
  2. Some of the suggested changes I could not understand. I made comments for the most important ones I noticed.
dvanderleij commented 4 years ago

Sure i'll create a PR for every commit there

dvanderleij commented 4 years ago

See #22 #23 #25 #24 #26 for the separate pr's they are numbered to be reviewed in order