search

refactoring-ai / Data-Collection

Collect refactorings with metrics from java source code.
MIT License
6 stars 1 forks source link

Cross-platform support #8

Open mauricioaniche opened 4 years ago

mauricioaniche commented 4 years ago

The tool is not working in Windows. Probable cause is how we deal with path names (the awesome / vs \ difference).

jan-gerling commented 4 years ago

I am working on this issue, in order to reduce number of failing tests.

jan-gerling commented 4 years ago

After the PR refactoring-ai/predicting-refactoring-ml#56:

Problem 1:

image

I am exploring this branch on fix/ProjectSizeComputation . The counting if the test file lines is failing, but the number of test files is counted correctly. image

I have no idea why the counting in the Counter.java is incorrect, any ideas? https://github.com/mauricioaniche/predicting-refactoring-ml/blob/dc95738147503ed7ea98f9ca3edfd8bc78029a20/data-collection/src/main/java/refactoringml/util/Counter.java#L20

Problem 2:

image image

This problem and the ones with the toy repos are solved by refactoring-ai/predicting-refactoring-ml#53.

jan-gerling commented 4 years ago

This issue needs further investigation.

Are all cross-platform issues resolved?

jan-gerling commented 4 years ago

The counting bug is back:

[ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 132.852 s <<< FAILURE! - in integration.realprojects.ApacheCommonsCSVIntegrationTest
[ERROR] integration.realprojects.ApacheCommonsCSVIntegrationTest.projectMetrics  Time elapsed: 0.003 s  <<< FAILURE!
java.lang.AssertionError: expected:<5140> but was:<5151>
    at integration.realprojects.ApacheCommonsCSVIntegrationTest.projectMetrics(ApacheCommonsCSVIntegrationTest.java:153)
mauricioaniche commented 4 years ago

I'd say let's just remove this assertion. Then, maybe we can write a simpler and more controlled test for the line counter.

jan-gerling commented 4 years ago

I'd say let's just remove this assertion. Then, maybe we can write a simpler and more controlled test for the line counter.

Sounds good.

mauricioaniche commented 4 years ago

@jan-gerling shall we close this one?